Fixed lint warnings in Grafana raised by Mixtool #22486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
changed the title
zeripath
approved these changes
Jan 17, 2023
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Jan 17, 2023
GiteaBot
added
lgtm/done
delvh
approved these changes
Jan 17, 2023
delvh
added
the
reviewed/wait-merge
yardenshoham
approved these changes
Jan 17, 2023
jolheiser
added
skip-changelog
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 18, 2023
* upstream/main: Simplify the error message when `index.js` couldn't be loaded (go-gitea#22354) Support asciicast files as new markup (go-gitea#22448) Support scoped access tokens (go-gitea#20908) some refactor about code comments (go-gitea#20821) docs: add swagger.json file location to FAQ (go-gitea#22489) docs: bump Gitea version (go-gitea#22490) chore: changelog 1.18.1 (go-gitea#22471) (go-gitea#22487) Fixed lint warnings in Grafana raised by Mixtool (go-gitea#22486) Set disable_gravatar/enable_federated_avatar when offline mode is true (go-gitea#22479) Fix pull request API field `closed_at` always being `null` (go-gitea#22482) Fix migration from gitbucket (repost) (go-gitea#22477)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a few minor changes to the gitea-monitoring-mixin, specifically linting issues raised by Mixtool:
jobandinstancehave been update to allow multi-selectjobandinstancetemplateAs this change is very minor I haven't created an issue, but please let me know if you'd like me to do so. According to the guidelines, it seemed to only be for larger designs :)