Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pidfile creation from setting to web cmd package #23285

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 4, 2023

Creating pid file should not belong to setting package and only web command needs that. So this PR moves pidfile creation from setting package to web command package to keep setting package more readable.

I marked this as break because the PIDFile path moved. For those who have used the pid build argument, it has to be changed.

@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Mar 4, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@7e3b7c2). Click here to learn what that means.
The diff coverage is 30.43%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #23285   +/-   ##
=======================================
  Coverage        ?   47.55%           
=======================================
  Files           ?     1148           
  Lines           ?   151201           
  Branches        ?        0           
=======================================
  Hits            ?    71908           
  Misses          ?    70788           
  Partials        ?     8505           
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
modules/setting/setting.go 46.66% <66.66%> (ø)
modules/setting/database.go 55.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2023
@lunny lunny requested review from zeripath and pat-s March 5, 2023 16:51
@pat-s
Copy link
Member

pat-s commented Mar 6, 2023

Why was I specifically request for review? I don't think I can add any expertise here 🙃

@pat-s pat-s removed their request for review March 6, 2023 16:21
@lunny
Copy link
Member Author

lunny commented Mar 7, 2023

Why was I specifically request for review? I don't think I can add any expertise here 🙃

You are recommended by Github. :) But he didn't give me reason.

cmd/web.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 15, 2023

Error response from daemon: No such image: gitea/test_env:linux-1.20-amd64

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2023
@lunny lunny merged commit 623a539 into go-gitea:main Mar 16, 2023
@lunny lunny deleted the lunny/improve_setting branch March 16, 2023 07:22
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 17, 2023
* giteaofficial/main:
  Use `<nav>` instead of `<div>` in the global navbar (go-gitea#23125)
  Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (go-gitea#23450)
  [skip ci] Updated translations via Crowdin
  Make time tooltips interactive (go-gitea#23526)
  Update mini-css-extract-plugin, remove postcss (go-gitea#23520)
  Fix review comment context menu clipped bug (go-gitea#23523)
  Add absent repounits to create/edit repo API (go-gitea#23500)
  Fix tags sort by creation time (descending) on branch/tag dropdowns  (go-gitea#23491)
  Allow both fullname and username search when `DEFAULT_SHOW_FULL_NAME` is true (go-gitea#23463)
  Handle files starting with colons in WalkGitLog (go-gitea#22935)
  Change `Close` to either `Close issue` or `Close pull request` (go-gitea#23506)
  Update act (go-gitea#23512)
  Move pidfile creation from setting to web cmd package (go-gitea#23285)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@delvh
Copy link
Member

delvh commented Jun 20, 2023

For those who have used the pid build argument, it has to be changed.

If I understood this PR correctly, that build flag is only for installing Gitea from source.
However, isn't that a one-time thing?
So, how would it be breaking?
Are there people who upgrade with a script while installing from source?

@lunny lunny removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants