Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion debug code for show/hide refactoring (#23576) #23868

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Apr 2, 2023

Backport #23576 by @wxiaoguang

When doing the refactoring:

I added some debug mode code (assertShown) to help to catch bugs, it did catch some bugs like:

If it has been proved that there is no more bugs, this assertion could be removed easily and clearly.

Feel free to decide when to remove it (feel free to convert it from Draft to Ready for Review).

cc: @silverwind

When doing the refactoring:

* go-gitea#22950

I added some debug mode code (assertShown) to help to catch bugs, it did
catch some bugs like:

* go-gitea#23074


If it has been proved that there is no more bugs, this assertion could
be removed easily and clearly.

Feel free to decide when to remove it (feel free to convert it from
Draft to Ready for Review).


cc: @silverwind
@GiteaBot GiteaBot added this to the 1.19.1 milestone Apr 2, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 2, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 2, 2023
@lunny lunny merged commit 026167f into go-gitea:release/v1.19 Apr 2, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 2, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@techknowlogick techknowlogick deleted the backport-23576-v1.19 branch September 9, 2023 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants