Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template function DateTime #24317

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Fix template function DateTime #24317

merged 4 commits into from
Apr 25, 2023

Conversation

wxiaoguang
Copy link
Contributor

Before, 500 error

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 25, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
yardenshoham
yardenshoham approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I knew string as an input doesn't make much sense but I didn't know the internal Time/TimeStamp types very well. Can we drop DateFmtLong now?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@wxiaoguang
Copy link
Contributor Author

Thanks for this. I knew string as an input doesn't make much sense but I didn't know the internal Time/TimeStamp types very well. Can we drop DateFmtLong now?

I think I can try to introduce TimeUtils in next PR and clean these helper functions together.

@wxiaoguang wxiaoguang mentioned this pull request Apr 25, 2023
Merged
@silverwind silverwind enabled auto-merge (squash) April 25, 2023 16:59
@silverwind silverwind merged commit 0e8045d into go-gitea:main Apr 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@yardenshoham yardenshoham mentioned this pull request Apr 25, 2023
Merged
@wxiaoguang wxiaoguang deleted the fix-datetime branch April 26, 2023 00:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3be44b5 
* giteaofficial/main:
  Fix broken clone script on an empty archived repo (go-gitea#24339)
  Improve RSS (go-gitea#24335)
  Automatically select the org when click create repo from org dashboard (go-gitea#24325)
  on schedule
  on schedule
  switch to use Actions from drone for cron (go-gitea#24314)
  [skip ci] Updated translations via Crowdin
  Restore bold on repolist (go-gitea#24337)
  Fix template function DateTime (go-gitea#24317)
  Fix incorrect CORS response in Http Git handler (go-gitea#24303)
  Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260)
  Add tags list for repos whose release setting is disabled (go-gitea#23465)
  Refactor config provider (go-gitea#24245)
  Add RSS Feeds for branches and files (go-gitea#22719)
  Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316)
  Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
techknowlogick pushed a commit that referenced this pull request Apr 26, 2023
@yardenshoham
Remove unnecessary helper function DateFmtLong (#24343)
eea23bb 
After #24317 this function is only used in one place where it is not
needed. I confirmed the timestamp still renders correctly

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @yardenshoham @silverwind @GiteaBot