Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chinese documentations for Packages (#24914) #25016

Merged
merged 6 commits into from
May 31, 2023
Merged

Add chinese documentations for Packages (#24914) #25016

merged 6 commits into from
May 31, 2023

Conversation

sillyguodong
Copy link
Contributor

backport: #24914

@GiteaBot GiteaBot added this to the 1.19.4 milestone May 31, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 31, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2023
@sillyguodong sillyguodong mentioned this pull request May 31, 2023
Merged
@sillyguodong sillyguodong added type/docs This PR mainly updates/creates documentation modifies/translation labels May 31, 2023
@lunny lunny merged commit 95bf09f into go-gitea:release/v1.19 May 31, 2023
@silverwind
Copy link
Member

This one seems to have brought a lint error onto 1.19:

https://drone.gitea.io/go-gitea/gitea/74958/1/4

docs/content/doc/packages/cran.zh-cn.md:93:3 MD047/single-trailing-newline Files should end with a single newline character

@sillyguodong
Copy link
Contributor Author

sillyguodong commented Jun 1, 2023 •
edited
Loading

This one seems to have brought a lint error onto 1.19:

will be fixed in #25022 🤦‍♂️

@silverwind silverwind mentioned this pull request Jun 1, 2023
Merged
@silverwind
Copy link
Member

Better fix in #25040 which also enables the linting.

jolheiser pushed a commit that referenced this pull request Jun 1, 2023
@silverwind
Run markdownlint on drone, fix lint issue (#25040)
b83e4f2 
It currently does not run on 1.19 branch, resulting in lint error having
landed in #25016.
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 7, 2023
@sillyguodong @earl-warren
Add chinese documentations for Packages (go-gitea#24914) (go-gitea#25016
e030d90 
)

backport: go-gitea#24914
(cherry picked from commit 95bf09f)
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 7, 2023
@silverwind @earl-warren
Run markdownlint on drone, fix lint issue (go-gitea#25040)
c5245fa 
It currently does not run on 1.19 branch, resulting in lint error having
landed in go-gitea#25016.

(cherry picked from commit b83e4f2)
@sillyguodong sillyguodong deleted the backport/pr_24914_to_1.19 branch July 11, 2023 08:21
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@HesterG HesterG HesterG approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.
6 participants
@sillyguodong @silverwind @Zettat123 @HesterG @lunny @GiteaBot