Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all deprecated setting fallback for v1.19 but keep warnning #25206

Closed
wants to merge 9 commits into from
Closed

Remove all deprecated setting fallback for v1.19 but keep warnning #25206

wants to merge 9 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 12, 2023 •
edited
Loading

This PR removes supports for all setting keys deprecated in v1.19 and will fatal if the keys are still using.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 12, 2023 •
edited
Loading

Instead of removing them, there should be a fatal error to tell users to update their config file.

If you do not remind the user, they will find that something never works again, because the old keys would never be used.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2023
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 13, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 13, 2023
@lunny
Copy link
Member Author

lunny commented Jun 13, 2023

replace #25148

@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jun 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2023
@lunny lunny mentioned this pull request Jun 20, 2023
Closed
@lunny lunny requested a review from wxiaoguang July 5, 2023 08:27
@wxiaoguang
Copy link
Contributor

Imagine a real case:

  1. User runs 1.21
  2. Fatal: "MAILER_TYPE is deprecated"
  3. Run again
  4. Fatal: "HOST is deprecated"
  5. Run again
  6. Fatal: "IS_TLS_ENABLED is deprecated"
  7. Run again
  8. Fatal: "DISABLE_HELO is deprecated"
  9. ...

If I was the user, I would go crazy.

So, to be most user-friendly, there needs a "config migration" tool.

At least, the fatal errors should be all shown in one fatal message.

@lunny
Copy link
Member Author

lunny commented Jul 21, 2023

So this should be created after #25994 resolved.

@lunny lunny closed this Jul 21, 2023
@GiteaBot GiteaBot removed this from the 1.21.0 milestone Jul 21, 2023
@lunny lunny deleted the lunny/remove_v1.19_setting branch July 21, 2023 04:38
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @silverwind @GiteaBot