Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity inconsistency when delete pull request #26285

Closed
wants to merge 3 commits into from
Closed

Fix activity inconsistency when delete pull request #26285

wants to merge 3 commits into from

Conversation

CaiCandong
Copy link
Member

@CaiCandong CaiCandong commented Aug 2, 2023 •
edited
Loading

Description：
When I delete a PR, I find that the entry is still in the feed stream on the home page. If I click on it, I get 404 and 500 errors.

Causes:
When deleting the Issue, the corresponding activity was deleted using issue.ID by mistake, when it should have used issue.Index.

Screenshot(gif):
gif

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 2, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2023
@CaiCandong CaiCandong changed the title Fix action inconssitency when delete pull request Fix activity inconssitency when delete pull request Aug 2, 2023
@CaiCandong CaiCandong changed the title Fix activity inconssitency when delete pull request Fix activity inconsistency when delete pull request Aug 2, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 2, 2023 •
edited
Loading

It's not right.

I fix it by the way in Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex #26279

Thank you for your finding and report 😆

@wxiaoguang wxiaoguang mentioned this pull request Aug 2, 2023
Merged
@CaiCandong
Copy link
Member Author

It's not right.

You're right, I didn't notice the operation related to comment .

@CaiCandong
Copy link
Member Author

CaiCandong commented Aug 2, 2023 •
edited
Loading

It's will be fixed in #26279

@CaiCandong CaiCandong closed this Aug 2, 2023
@CaiCandong CaiCandong reopened this Aug 5, 2023
@delvh delvh added the backport/v1.20 This PR should be backported to Gitea 1.20 label Aug 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 6, 2023
wxiaoguang
wxiaoguang requested changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review #26279 which has a full fix for this problem and has tests.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2023
@delvh delvh closed this in #26279 Aug 7, 2023
delvh pushed a commit that referenced this pull request Aug 7, 2023
@wxiaoguang
Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect I…
e4b1ea6 
…ssueIndex (#26279)

Close #26277
Fix #26285
@GiteaBot GiteaBot mentioned this pull request Aug 7, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 7, 2023
@wxiaoguang @GiteaBot
Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect I…
3c86fde 
…ssueIndex (go-gitea#26279)

Close go-gitea#26277
Fix go-gitea#26285
lunny pushed a commit that referenced this pull request Aug 7, 2023
@GiteaBot @wxiaoguang
Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect I…
cb1a4da 
…ssueIndex (#26279) (#26368)

Backport #26279 by @wxiaoguang

Close #26277
Fix #26285

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@CaiCandong CaiCandong deleted the fix-action-inconsistency-when-delete-pr branch August 11, 2023 02:08
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaiCandong @wxiaoguang @delvh @GiteaBot