Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer dereference error when open link with invalid pull index #26353

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

CaiCandong
Copy link
Member

fix #26331

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2023
routers/web/repo/pull.go Outdated Show resolved Hide resolved
@lunny lunny added the type/bug label Aug 6, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2023
routers/web/repo/pull.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 6, 2023
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 6, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 7, 2023
@lunny lunny merged commit 24fbf4e into go-gitea:main Aug 7, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 7, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 7, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 8, 2023
* upstream/main:
  Start using template context function (go-gitea#26254)
  Allow package cleanup from admin page (go-gitea#25307)
  Fix text truncate (go-gitea#26354)
  Fix incorrect sort link with  `.profile`  repository (go-gitea#26374)
  Use more `IssueList` instead of `[]*Issue` (go-gitea#26369)
  Rename code_langauge.go to code_language.go (go-gitea#26377)
  Add changelog for 1.20.3 (go-gitea#26373)
  Do not highlight `#number` in documents (go-gitea#26365)
  Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (go-gitea#26279)
  Fix nil pointer dereference  error when open link with invalid pull index (go-gitea#26353)
@CaiCandong CaiCandong deleted the bugfix/issue_26331 branch August 11, 2023 02:07
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PANIC: runtime error: invalid memory address or nil pointer dereference
4 participants