Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpg tmpl #3153

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix gpg tmpl #3153

merged 1 commit into from
Dec 11, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2017

As title.

@lunny lunny added the type/bug label Dec 11, 2017
@lunny lunny added this to the 1.4.0 milestone Dec 11, 2017
@lafriks
Copy link
Member

lafriks commented Dec 11, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2017
@sapk
Copy link
Member

sapk commented Dec 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2017
@codecov-io
Copy link

Codecov Report

Merging #3153 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   34.74%   34.74%   +<.01%     
==========================================
  Files         276      276              
  Lines       39945    39945              
==========================================
+ Hits        13877    13880       +3     
+ Misses      24074    24071       -3     
  Partials     1994     1994
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/issue.go 45.02% <0%> (+0.2%) ⬆️
models/error.go 33.63% <0%> (+0.61%) ⬆️
models/issue_indexer.go 67.53% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82519c...abf1fae. Read the comment docs.

@lunny lunny merged commit 3b525d5 into go-gitea:master Dec 11, 2017
@lunny lunny deleted the lunny/fix_gpg_tmpl branch December 11, 2017 14:08
@sapk sapk mentioned this pull request Dec 11, 2017
Closed
7 tasks
@lunny
Copy link
Member Author

lunny commented Dec 11, 2017

fixed #3151

@sapk sapk mentioned this pull request Aug 13, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @lafriks @sapk @codecov-io @tboerger