Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mssql ci with a new mssql version on ci #32094

Open
wants to merge 1 commit into
base: release/v1.22
Choose a base branch
from

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 20, 2024

backport from #32060

@GiteaBot GiteaBot added this to the 1.22.3 milestone Sep 20, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Sep 22, 2024

On 2024-09-20T16:35:23Z, techknowlogick said my resolution (this change) "is not the correct one", and he was "working on it" and "might even involve building a custom image" (although I don't quite agree due to various reasons)

So, would you like to wait for him?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants