-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use APP_NAME on home page #5048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would it make sense to actually use the configured app name on the home page?
Codecov Report
@@ Coverage Diff @@
## master #5048 +/- ##
=========================================
- Coverage 37.41% 37.4% -0.01%
=========================================
Files 306 306
Lines 45389 45389
=========================================
- Hits 16981 16977 -4
- Misses 25954 25956 +2
- Partials 2454 2456 +2
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 9, 2018
appleboy
approved these changes
Oct 9, 2018
bkcsoft
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 9, 2018
I was considering making a PR for this myself. Thanks! |
lafriks
approved these changes
Oct 9, 2018
bkcsoft
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it make sense to actually use the configured app name on the home page?