Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlite deadlock when assigning to a PR (#5640) (Backport to v1.7) #5642

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 5, 2019

When assigning a user to a PR there was a call to issue.PullRequest.APIFormat() which causes an deadlock in sqlite due to the internal use of the xorm engine. This PR changes this to issue.PullRequest.apiFormat(sess) passing in the current session and thus avoiding the deadlock.

Fix #5639

* Fix sqlite deadlock when assigning to a PR

Fix 5639

Signed-off-by: Andrew Thornton <art27@cantab.net>

* More possible deadlocks found and fixed

Signed-off-by: Andrew Thornton <art27@cantab.net>
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 5, 2019
@lunny lunny added this to the 1.7.0 milestone Jan 5, 2019
@lunny lunny added the type/bug label Jan 5, 2019
@lunny
Copy link
Member

lunny commented Jan 5, 2019

backport from #5640

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2019
@techknowlogick techknowlogick merged commit 2904d8d into go-gitea:release/v1.7 Jan 5, 2019
@zeripath zeripath deleted the issue-5639-fix-deadlock branch January 9, 2019 17:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants