-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make db connect more robust #5738
Merged
techknowlogick
merged 22 commits into
go-gitea:master
from
pbrackin:Make_DB_Connect_More_Robust
Jan 19, 2019
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a3937ad
Add retry loop to DB connect logic
461665d
make DB connect vars configurable
a2122a6
Merge branch 'master' into Make_DB_Connect_More_Robust
techknowlogick 16db020
Update DB retry field names, add as setting subfield, add to US local…
b74d936
spaces->tabs
5dc2abc
fix new DB setting declaration
38dbb4d
Add retry loop to DB connect logic
f6fb9aa
Support CORS headers to git smart http protocol (#5719)
lunny aa178f7
make DB connect vars configurable
72c624f
Update DB retry field names, add as setting subfield, add to US local…
2f6f57a
spaces->tabs
8544971
fix new DB setting declaration
d57e3a4
Merge branch 'Make_DB_Connect_More_Robust' of github.com:pbrackin/git…
990691b
Moving retry logic to separate func. More spaces->tabs.
9113c75
spaces->tabs
602159c
fix spacing fmt gripe, I think.
c2060d0
add additional logging per connect attempt
eb90cc7
Merge branch 'master' into Make_DB_Connect_More_Robust
techknowlogick eff081e
Change backoff timer ini setting to a Duration vs constant
edb820d
Merge branch 'Make_DB_Connect_More_Robust' of github.com:pbrackin/git…
9b6c7ef
Update backoff timer to Duration in cheatsheet
b05babf
Merge branch 'master' into Make_DB_Connect_More_Robust
techknowlogick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here should have been:
The reason the compiler didn't alarm is because there was a named err always available. I knew I never liked that feature of the language!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ur right. I did have it that way the first go around, then I changed it due to a compile error (which was for another unrelated problem). I currently have em on separate lines tho. u want me to condense it back down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Push your current changes up, and let's see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed it already. It didn't show up here I guess becz its merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I hit the "compare & new PR" button. u reckon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well i went ahead and condensed it back down to a one-liner, sans the re-declaration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK the new PR is is #5780