In gitea serv switch off console logger to fix #5866 #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default warning logs are printed to the stdout which breaks a git receive-pack etc. This PR disables the console logger whilst in serv.go Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5887 +/- ##
==========================================
+ Coverage 38.27% 38.29% +0.01%
==========================================
Files 330 330
Lines 48518 48518
==========================================
+ Hits 18572 18578 +6
+ Misses 27273 27266 -7
- Partials 2673 2674 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
Maybe del the logger after |
|
I think it's fine for Gitea serv to be silent for these warnings - it's not meant to be used by humans. Emitting anything on the console will break git causing it to hang on the client. |
|
Basically without this PR - If warnings are emitted because of a minor problem in app.ini that doesn't stop gitea from running - you cannot push or pull over ssh. |
techknowlogick
approved these changes
Feb 3, 2019
GiteaBot
added
lgtm/need 1
kolaente
approved these changes
Feb 3, 2019
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 3, 2019
By default, if `setting.NewContext()` prints out any warning logs, these are printed to the stdout breaking `git receive-pack` etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you **CANNOT** push or pull over SSH. This PR disables the console logger whilst in `serv.go` Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
Feb 3, 2019
By default, if `setting.NewContext()` prints out any warning logs, these are printed to the stdout breaking `git receive-pack` etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you **CANNOT** push or pull over SSH. This PR disables the console logger whilst in `serv.go` Signed-off-by: Andrew Thornton <art27@cantab.net>
7 tasks
GiteaBot
added
the
pr/breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, if
setting.NewContext()prints out any warning logs, these are printed to the stdout breakinggit receive-packetc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you CANNOT push or pull over SSH.This PR disables the console logger whilst in
serv.goFix #5866
Signed-off-by: Andrew Thornton art27@cantab.net