Recover panic in orgmode.Render if bad orgfile (#4982) #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR protects against the panic referred to in chaseadmsio/goorgeous#82 by recovering from the panic and just returning the raw bytes if there is an error. Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5903 +/- ##
=========================================
Coverage ? 37.96%
=========================================
Files ? 329
Lines ? 48404
Branches ? 0
=========================================
Hits ? 18378
Misses ? 27385
Partials ? 2641
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Jan 30, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jan 30, 2019
GiteaBot
added
lgtm/done
|
Maybe you could send a back port to v1.7? |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 16, 2019
…tea#5903) This PR protects against the panic referred to in chaseadmsio/goorgeous#82 by recovering from the panic and just returning the raw bytes if there is an error. Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
pushed a commit
that referenced
this pull request
Feb 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR protects against the panic referred to in chaseadamsio/_goorgeous#82
by recovering from the panic and just returning the raw bytes if
there is an error.
Fix #4982 Fix #5430
Signed-off-by: Andrew Thornton art27@cantab.net