Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Repo header tweaks #5945

Merged
merged 7 commits into from
Feb 5, 2019
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 3, 2019

  • Use basic buttons on the header buttons, matching gogs
  • Make 'Manage topic' text smaller, remove margin-left with no topics
    present
  • Move various inline styles to CSS
  • Use flexbox on header title and buttons

Before

screenshot 2019-02-03 at 17 55 27

After

screenshot 2019-02-03 at 20 11 01

Note: The missing icon on the watch button is not related to this commit, some kind of font cache issue on my side.

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c20034b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5945   +/-   ##
========================================
  Coverage          ?   38.7%           
========================================
  Files             ?     330           
  Lines             ?   48642           
  Branches          ?       0           
========================================
  Hits              ?   18825           
  Misses            ?   27090           
  Partials          ?    2727

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20034b...9a7f322. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2019
- Use basic buttons on the header buttons, matching gogs
- Make 'Manage topic' text smaller, remove margin-left with no topics
present
- Move various inline styles to CSS
- Use flexbox on header title and buttons
@media only screen and (max-width: 768px) {
width: 100%;
}
@media only screen and (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting looks a little off

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't really off, just made it consistent to 4-space indent. But now that I look at it, I'm not sure this will even work, you usually wrap selectors inside a media query, not the other way around, fixing that.

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 3, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019
@silverwind
Copy link
Member Author

After screenshot updated, now centered .repo-title vertically.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2019
@techknowlogick techknowlogick merged commit acaf5c9 into go-gitea:master Feb 5, 2019
@jolheiser jolheiser mentioned this pull request Feb 6, 2019
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants