Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label names as filter in issue search api #5946

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 3, 2019

I am working on some sort of Gitea integration that needs to comment on a list of issues
with a certain label. I don't want to manually keep track of the label ID for each repository
I am running the service against.

Sample request:

http://localhost:3000/api/v1/repos/damn/KKKKK/issues?labels=bug,duplicate

@adelowo adelowo force-pushed the add_labels_as_filter_in_issue_search_api branch 3 times, most recently from 3c2bf2f to 3614fd8 Compare February 3, 2019 18:50
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Feb 3, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019
@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f21ae12). Click here to learn what that means.
The diff coverage is 80.95%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5946   +/-   ##
========================================
  Coverage          ?   38.7%           
========================================
  Files             ?     330           
  Lines             ?   48593           
  Branches          ?       0           
========================================
  Hits              ?   18809           
  Misses            ?   27062           
  Partials          ?    2722
Impacted Files Coverage Δ
models/issue_label.go 60.74% <100%> (ø)
routers/api/v1/repo/issue.go 31.26% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21ae12...44870b7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 4, 2019
models/issue_label.go Outdated Show resolved Hide resolved
@adelowo adelowo force-pushed the add_labels_as_filter_in_issue_search_api branch from 4cce53f to cc61ce1 Compare February 4, 2019 08:37
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 4, 2019
@techknowlogick techknowlogick merged commit 024871a into go-gitea:master Feb 4, 2019
@adelowo adelowo deleted the add_labels_as_filter_in_issue_search_api branch February 4, 2019 15:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants