-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance release list #6025
Merged
techknowlogick
merged 33 commits into
go-gitea:master
from
adelowo:enhance_release_list
Oct 22, 2020
Merged
Enhance release list #6025
Changes from 20 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5f123b0
show author for releases created outside Gitea UI.
adelowo 09fef96
add migration for already existing tags
adelowo b453340
update as per review
adelowo f985e2c
fix merge conflicts
adelowo 92b7dfd
Merge remote-tracking branch 'origin' into enhance_release_list
adelowo e50fe8d
Merge remote-tracking branch 'origin' into enhance_release_list
adelowo 4eb786e
fix build
adelowo 9fcf2cc
add space
adelowo cf5575d
fix import statments
adelowo d2a6fd9
Merge branch 'master' of github.com:go-gitea/gitea into enhance_relea…
adelowo 8923c20
Merge branch 'master' into enhance_release_list
zeripath eb4c10d
Update models/migrations/v113.go
adelowo 19a6d50
Merge branch 'master' of github.com:go-gitea/gitea into enhance_relea…
adelowo cc55d98
Merge branch 'master' of github.com:go-gitea/gitea into enhance_relea…
adelowo 9359f3d
Update models/migrations/v114.go
adelowo fb41b03
Update services/release/release.go
adelowo c0f4a50
Merge branch 'master' into enhance_release_list
adelowo 5978c2d
Merge branch 'master' into enhance_release_list
6543 717b18a
Merge branch 'master' into enhance_release_list
adelowo 725ac8f
impruve
6543 9804f94
Merge branch 'master' into enhance_release_list
6543 78dceb3
Merge branch 'master' into enhance_release_list
6543 5a3fb34
remove dependency on models package
adelowo 4f61e67
Merge branch 'master' of github.com:go-gitea/gitea into enhance_relea…
adelowo 79c144d
Merge branch 'master' into enhance_release_list
6543 5688b34
Close the gitrepos in a defer to ensure that they are closed.
zeripath 4158361
Merge branch 'master' into enhance_release_list
6543 3b1541f
Merge branch 'master' into enhance_release_list
adelowo d7ff241
gofmt
6543 19d43d5
Merge branch 'master' into enhance_release_list
6543 0ad085d
Merge branch 'master' into enhance_release_list
6543 4d85686
Merge branch 'master' into enhance_release_list
techknowlogick f90eb0f
Merge branch 'master' into enhance_release_list
6543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
// Copyright 2020 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package migrations | ||
|
||
import ( | ||
"fmt" | ||
|
||
"code.gitea.io/gitea/models" | ||
"code.gitea.io/gitea/modules/git" | ||
|
||
"xorm.io/xorm" | ||
) | ||
|
||
func fixPublisherIDforTagReleases(x *xorm.Engine) error { | ||
|
||
type Release struct { | ||
ID int64 | ||
RepoID int64 | ||
Sha1 string | ||
TagName string | ||
PublisherID int64 | ||
} | ||
|
||
type Repository struct { | ||
ID int64 | ||
OwnerID int64 | ||
Name string | ||
} | ||
|
||
type User struct { | ||
ID int64 | ||
Name string | ||
Email string | ||
} | ||
|
||
const batchSize = 100 | ||
sess := x.NewSession() | ||
defer sess.Close() | ||
|
||
if err := sess.Begin(); err != nil { | ||
return err | ||
} | ||
|
||
var ( | ||
gitRepoCache = make(map[int64]*git.Repository) | ||
gitRepo *git.Repository | ||
repoCache = make(map[int64]*Repository) | ||
userCache = make(map[int64]*User) | ||
ok bool | ||
err error | ||
) | ||
|
||
for start := 0; ; start += batchSize { | ||
releases := make([]*Release, 0, batchSize) | ||
|
||
if err := sess.Limit(batchSize, start).Asc("id").Where("is_tag=?", true).Find(&releases); err != nil { | ||
return err | ||
} | ||
|
||
if len(releases) == 0 { | ||
break | ||
} | ||
|
||
for _, release := range releases { | ||
gitRepo, ok = gitRepoCache[release.RepoID] | ||
if !ok { | ||
repo, ok := repoCache[release.RepoID] | ||
if !ok { | ||
repo = new(Repository) | ||
has, err := sess.ID(release.RepoID).Get(repo) | ||
if err != nil { | ||
return err | ||
} else if !has { | ||
return fmt.Errorf("Repository %d is not exist", release.RepoID) | ||
} | ||
|
||
repoCache[release.RepoID] = repo | ||
} | ||
|
||
user, ok := userCache[repo.OwnerID] | ||
if !ok { | ||
user = new(User) | ||
has, err := sess.ID(repo.OwnerID).Get(user) | ||
if err != nil { | ||
return err | ||
} else if !has { | ||
return fmt.Errorf("User %d is not exist", repo.OwnerID) | ||
} | ||
|
||
userCache[repo.OwnerID] = user | ||
} | ||
|
||
gitRepo, err = git.OpenRepository(models.RepoPath(user.Name, repo.Name)) | ||
if err != nil { | ||
return err | ||
} | ||
gitRepoCache[release.RepoID] = gitRepo | ||
} | ||
|
||
commit, err := gitRepo.GetTagCommit(release.TagName) | ||
if err != nil { | ||
return fmt.Errorf("GetTagCommit: %v", err) | ||
} | ||
|
||
u := new(User) | ||
exists, err := sess.Where("email=?", commit.Author.Email).Get(u) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if !exists { | ||
continue | ||
} | ||
|
||
release.PublisherID = u.ID | ||
if _, err := sess.ID(release.ID).Cols("publisher_id").Update(release); err != nil { | ||
return err | ||
} | ||
} | ||
} | ||
|
||
for i := range gitRepoCache { | ||
gitRepoCache[i].Close() | ||
} | ||
|
||
return sess.Commit() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer close?