Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to more recent build of xgo #6070

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Switch to more recent build of xgo #6070

merged 2 commits into from
Feb 14, 2019

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Feb 14, 2019 •
edited
Loading

As title

@techknowlogick techknowlogick added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Feb 14, 2019
@codecov-io
Copy link

codecov-io commented Feb 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7a72aa6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6070   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      345           
  Lines             ?    49507           
  Branches          ?        0           
=========================================
  Hits              ?    19239           
  Misses            ?    27486           
  Partials          ?     2782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a72aa6...e5c03e6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2019
@techknowlogick techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Feb 14, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 14, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 14, 2019
kolaente
kolaente approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the longer run, we should maybe move this to the Gitea org.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2019
@lafriks lafriks merged commit 18d0662 into go-gitea:master Feb 14, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-13 branch February 14, 2019 18:20
@techknowlogick techknowlogick mentioned this pull request Feb 14, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Feb 14, 2019
techknowlogick added a commit that referenced this pull request Feb 14, 2019
@techknowlogick
Switch to more recent build of xgo (#6070) (#6072)
3ac4a7f
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @codecov-io @adelowo @kolaente @lafriks @GiteaBot