-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double-close of issues #6233
Merged
techknowlogick
merged 3 commits into
go-gitea:master
from
zeripath:prevent-negative-num-closed-pulls
Mar 5, 2019
Merged
Prevent double-close of issues #6233
techknowlogick
merged 3 commits into
go-gitea:master
from
zeripath:prevent-negative-num-closed-pulls
Mar 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6233 +/- ##
==========================================
- Coverage 38.84% 38.83% -0.02%
==========================================
Files 355 355
Lines 50239 50243 +4
==========================================
- Hits 19516 19512 -4
- Misses 27897 27903 +6
- Partials 2826 2828 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 3, 2019
lafriks
reviewed
Mar 3, 2019
Co-Authored-By: zeripath <art27@cantab.net>
lafriks
approved these changes
Mar 4, 2019
GiteaBot
removed
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 4, 2019
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Mar 4, 2019
adelowo
approved these changes
Mar 4, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 4, 2019
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible to end double-closing issues thus leading to a negative number of pulls remaining to be closed. This PR reloads the issue from the database within the transaction and checks that it isn't already closed in the database.