WIP: Support new file/upload file buttons on empty repo home page #6918

lunny · 2019-05-12T09:29:06Z

xf- · 2019-05-12T10:26:15Z

Maybe add the right portion of the normal bar on the top left side and set Download on disabled:

This would be a much more constant UI and user expierence

lunny · 2019-05-12T13:03:23Z

@xf- I don't think that's better than current design.

codecov-io · 2019-05-12T13:08:20Z

Codecov Report

Merging #6918 (3306e2d) into master (41c0776) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6918      +/-   ##
==========================================
+ Coverage   42.09%   42.10%   +0.01%     
==========================================
  Files         758      758              
  Lines       81106    81121      +15     
==========================================
+ Hits        34139    34157      +18     
+ Misses      41386    41385       -1     
+ Partials     5581     5579       -2

Impacted Files	Coverage Δ
modules/context/repo.go	`55.51% <100.00%> (+0.57%)`	⬆️
modules/repofiles/update.go	`37.60% <100.00%> (+0.51%)`	⬆️
routers/repo/view.go	`41.94% <100.00%> (+0.36%)`	⬆️
routers/routes/web.go	`91.58% <100.00%> (+0.03%)`	⬆️
modules/log/event.go	`59.90% <0.00%> (-1.89%)`	⬇️
modules/git/repo_commit_nogogit.go	`63.33% <0.00%> (-1.67%)`	⬇️
modules/indexer/stats/db.go	`68.00% <0.00%> (ø)`
services/pull/pull.go	`42.64% <0.00%> (+0.49%)`	⬆️
models/unit.go	`49.31% <0.00%> (+2.73%)`	⬆️
modules/git/repo_language_stats_nogogit.go	`61.70% <0.00%> (+4.25%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c0776...3306e2d. Read the comment docs.

techknowlogick · 2019-05-15T12:59:31Z

modules/repofiles/temp_repo.go

-				Name: branch,
+	if t.repo.IsEmpty {
+		if _, stderr, err := process.GetManager().ExecTimeout(5*time.Minute,
+			fmt.Sprintf("Clone (git clone -s --bare): %s", t.basePath),


Can you move this command exec to git package?

techknowlogick · 2019-05-15T12:59:44Z

modules/repofiles/temp_repo.go

+	} else {
+		if _, stderr, err := process.GetManager().ExecTimeout(5*time.Minute,
+			fmt.Sprintf("Clone (git clone -s --bare): %s", t.basePath),
+			"git", "clone", "-s", "--bare", "-b", branch, t.repo.RepoPath(), t.basePath); err != nil {


techknowlogick · 2019-05-15T13:00:05Z

modules/repofiles/temp_repo.go

+			t.basePath,
+			fmt.Sprintf("commitTree (git commit-tree): %s", t.basePath),
+			env,
+			"git", "commit-tree", treeHash, "-m", message)


silverwind · 2019-05-16T16:56:46Z

Think I'd also prefer having those button beside the clone URL. As an alternative, a bit less padding could also work. Or maybe even move the buttons into the header on the top-right.

techknowlogick · 2019-05-16T19:33:30Z

I like the idea of having the buttons next to clone, because that is what it is like when files are in the repo. So it would keep things the same for users.

If we don't have it next to clone, I like @silverwind's alternative of having less padding.

A third alternative is to make the buttons Giant, so they fill up the empty whitespace.

Here is a screenshot of what GitHub does, but I don't like how they made the create/upload actions text:

(sidenote: thanks @silverwind for GitHub dark theme)

silverwind · 2019-05-16T19:38:45Z

I like the idea of subtle text links. No need for big distracting buttons when most people will probably want to initizalize a repo through other means.

mrsdizzie · 2019-05-16T20:43:01Z

Agree it seems odd not to just have it in the same spot as every other page. Consistency across pages seems more important than anything else for this case

stale · 2019-09-05T02:38:54Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

lunny · 2019-12-20T12:15:03Z

Should fix #4308

delvh · 2021-02-12T13:45:59Z

As of #14633, there is the request to include this ability also for the API.
Has that already been included in this branch?
Is that even the correct branch for that feature? I'd say so as it basically is concerned with the same topic, just from a slightly different perspective.
Or should a new branch be opened for that feature once this branch gets merged?

lunny · 2021-02-13T16:20:01Z

It will not be very difficult once this PR merged.

jhult · 2021-06-01T19:09:58Z

@lunny, any news on this PR? It would be a great feature to have.

lunny · 2021-06-02T01:02:34Z

@lunny, any news on this PR? It would be a great feature to have.

Will continue this PR after some PRs merged.

mikeperalta1 · 2022-08-25T05:54:32Z

Any update on this?

lunny · 2022-12-11T13:28:35Z

The code base has been changed a lot since this PR opened, just close it.

ScarUY · 2023-01-18T13:48:54Z

So, no way to add /create new file/s from the web ui? Honest question, I just installed it (rootless docker) and I'm stumped...

lunny · 2023-01-18T15:42:41Z

No, you could add /create new file/s from the web ui on a non-empty repository.
This PR is for empty repository.

wxiaoguang · 2023-04-20T04:17:05Z

Allow adding new files to an empty repo #24164

All related issues could be re-reviewed and closed.

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 12, 2019

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2019

techknowlogick reviewed May 15, 2019

View reviewed changes

lunny added this to the 1.10.0 milestone Jul 7, 2019

stale bot added the issue/stale label Sep 5, 2019

lunny modified the milestones: 1.10.0, 1.11.0 Sep 5, 2019

stale bot removed the issue/stale label Sep 5, 2019

lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/stale labels Sep 5, 2019

stale bot removed the issue/stale label Sep 5, 2019

lunny modified the milestones: 1.11.0, 1.12.0 Dec 13, 2019

lunny modified the milestones: 1.12.0, 1.13.0 May 2, 2020

lunny modified the milestones: 1.13.0, 1.14.0 Sep 1, 2020

lunny force-pushed the lunny/new_file_blank_repo branch 2 times, most recently from f784d08 to 348d94d Compare January 3, 2021 05:22

lunny modified the milestones: 1.14.0, 1.15.0 Feb 6, 2021

delvh mentioned this pull request Feb 12, 2021

API: unable to post a first file to the empty repository #14633

Closed

jolheiser mentioned this pull request Apr 1, 2021

Create new file from the web ui when the repo is created #4308

Closed

7 tasks

zeripath modified the milestones: 1.15.0, 1.16.0 Jun 23, 2021

lunny mentioned this pull request Jul 14, 2021

Plan of Gitea v1.16 #16429

Closed

lunny added 5 commits November 22, 2021 16:16

fix template

07f0dd0

Use new buttons

aafb8b0

Add buttons on empty repository page

ccacb8a

allow create new file on empty repository

f5dd276

Update

32ed105

lunny force-pushed the lunny/new_file_blank_repo branch from 3306e2d to 32ed105 Compare November 22, 2021 08:16

techknowlogick modified the milestones: 1.16.0, 1.17.0 Nov 23, 2021

lunny modified the milestones: 1.17.0, 1.x.x May 26, 2022

lunny removed this from the 1.x.x milestone Dec 11, 2022

lunny closed this Dec 11, 2022

lunny deleted the lunny/new_file_blank_repo branch December 11, 2022 13:28

go-gitea locked and limited conversation to collaborators Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Support new file/upload file buttons on empty repo home page #6918

WIP: Support new file/upload file buttons on empty repo home page #6918

lunny commented May 12, 2019

xf- commented May 12, 2019

lunny commented May 12, 2019

codecov-io commented May 12, 2019 •

edited

Loading

techknowlogick May 15, 2019

techknowlogick May 15, 2019

techknowlogick May 15, 2019

silverwind commented May 16, 2019

techknowlogick commented May 16, 2019

silverwind commented May 16, 2019

mrsdizzie commented May 16, 2019

stale bot commented Sep 5, 2019

lunny commented Dec 20, 2019

delvh commented Feb 12, 2021

lunny commented Feb 13, 2021

jhult commented Jun 1, 2021

lunny commented Jun 2, 2021

mikeperalta1 commented Aug 25, 2022

lunny commented Dec 11, 2022

ScarUY commented Jan 18, 2023

lunny commented Jan 18, 2023

wxiaoguang commented Apr 20, 2023

WIP: Support new file/upload file buttons on empty repo home page #6918

WIP: Support new file/upload file buttons on empty repo home page #6918

Conversation

lunny commented May 12, 2019

xf- commented May 12, 2019

lunny commented May 12, 2019

codecov-io commented May 12, 2019 • edited Loading

Codecov Report

techknowlogick May 15, 2019

Choose a reason for hiding this comment

techknowlogick May 15, 2019

Choose a reason for hiding this comment

techknowlogick May 15, 2019

Choose a reason for hiding this comment

silverwind commented May 16, 2019

techknowlogick commented May 16, 2019

silverwind commented May 16, 2019

mrsdizzie commented May 16, 2019

stale bot commented Sep 5, 2019

lunny commented Dec 20, 2019

delvh commented Feb 12, 2021

lunny commented Feb 13, 2021

jhult commented Jun 1, 2021

lunny commented Jun 2, 2021

mikeperalta1 commented Aug 25, 2022

lunny commented Dec 11, 2022

ScarUY commented Jan 18, 2023

lunny commented Jan 18, 2023

wxiaoguang commented Apr 20, 2023

codecov-io commented May 12, 2019 •

edited

Loading