Introduce go chi web framework as frontend of macaron, so that we can move routes from macaron to chi step by step #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
added
the
issue/confirmed
|
related with #7403 |
lunny
changed the title
lunny
added
the
type/refactoring
This was referenced Nov 12, 2020
6543
approved these changes
Nov 12, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Nov 12, 2020
GiteaBot
added
lgtm/done
lafriks
requested changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #7420 +/- ##
==========================================
+ Coverage 42.17% 42.19% +0.02%
==========================================
Files 695 696 +1
Lines 76370 76407 +37
==========================================
+ Hits 32206 32241 +35
- Misses 38880 38885 +5
+ Partials 5284 5281 -3
Continue to review full report at Codecov.
|
…be easier to migrate macaron routes to chi routes later
|
@lafriks done. |
6543
approved these changes
Nov 13, 2020
|
@lunny the chi router do not pass things to our logger :/ |
lafriks
approved these changes
Nov 13, 2020
|
🚀 |
|
LGTM does not seems to like me :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #7403, we should chose go-chi as Gitea's backend web framework.
Why we should move away from macaron, see @zeripath 's comment #7403 (comment)
This PR will not finish all the work to remove macaron, but it will introduce go chi as the frontend of macaron. Only most middlewares and serval routes will be handled by go chi, and most routes will still be handled by macaron. To implement that, a go chi middleware is written to delegate the HTTP requests to macaron.
A difference between chi and macaron is macaron will set req.Body back but chi will not after consumed the request. That's why the changes to the test is in this PR.
It's ready to review now.