Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows external rendering of other filetypes #8295

Closed
wants to merge 6 commits into from
Closed

Allows external rendering of other filetypes #8295

wants to merge 6 commits into from

Conversation

HarvsG
Copy link
Contributor

@HarvsG HarvsG commented Sep 26, 2019

Fixes #4996 and #7614
allows rendering of non-text files, or otherwise un-accounted for filetypes

HarvsG and others added 4 commits September 26, 2019 20:19
@HarvsG
allow external rendering of other filetypes
c51ed90 
fixes #4996 and #7614 
allows rendering of non-tex files, or otherwise accounted for filetypes
@HarvsG
Merge branch 'master' into master
56cd108
@lunny
Extract actions on new pull request from models to pulls service and …
eb11ca6 
…move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull (#8218)

* extract actions on new pull request from models to pulls service

* improve code

* move code.gitea.io/gitea/modules/pull to code.gitea.io/gitea/services/pull

* fix fmt

* Rename pulls.go to pull.go
@davidsvantesson @lunny
Fix API for edit and delete release attachment (#8285)
c6fb7fe 
* Add logging for when user requested attachment doesn't belong to the specified release.

* Fix API to use correct variable for release asset (attachment)
lafriks
lafriks requested changes Sep 27, 2019
View reviewed changes
routers/repo/view.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2019
HarvsG
HarvsG commented Sep 27, 2019
View reviewed changes
Copy link
Contributor Author

@HarvsG HarvsG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafriks. Agreed, I have made the changes. I wonder if it might also be worth incorporating the fix I have suggested for #8299, to keep this to a single PR.

@codecov-io
Copy link

Codecov Report

Merging #8295 into master will decrease coverage by <.01%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8295      +/-   ##
==========================================
- Coverage   41.52%   41.52%   -0.01%     
==========================================
  Files         493      494       +1     
  Lines       65376    65396      +20     
==========================================
+ Hits        27150    27155       +5     
- Misses      34729    34744      +15     
  Partials     3497     3497
Impacted Files Coverage Δ
services/pull/review.go 0% <ø> (ø)
services/pull/lfs.go 71.16% <ø> (ø)
services/pull/commit_status.go 10% <ø> (ø)
models/pull.go 54.3% <ø> (-0.62%) ⬇️
routers/repo/pull_review.go 0% <ø> (ø) ⬆️
services/pull/merge.go 36.9% <ø> (ø)
routers/api/v1/repo/pull.go 37.04% <0%> (ø) ⬆️
routers/api/v1/repo/release_attachment.go 0% <0%> (ø) ⬆️
routers/repo/view.go 42.26% <0%> (-1.29%) ⬇️
routers/repo/pull.go 30.2% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d958b9d...e594aee. Read the comment docs.

@guillep2k
Copy link
Member

I don't understand, why do changes from other PRs show up as changes here? Normally when master is merged into the PR the changes don't show up. Is this an EOL issue?

@HarvsG
Copy link
Contributor Author

HarvsG commented Sep 27, 2019 •
edited
Loading

@guillep2k It is possible I did a git pull with gitea/gitea still set as my remote? I'm not sure how to revert this without closing the PR and re-opening

Edit:
I have created a new PR #8300 without the offending commits. So feel free to close this one and move discussion there.

Apologies for the inconvenience.

@guillep2k
Copy link
Member

@HarvsG I don't see the problem if you need to open a new PR. Just reference it here (you need of course to create another branch).

@guillep2k
Copy link
Member

You can cherry-pick your own commits, I guess.

@HarvsG HarvsG mentioned this pull request Sep 27, 2019
Merged
@guillep2k
Copy link
Member

You should close this PR.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks requested changes

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply external markup rendering to non-text files
8 participants
@HarvsG @codecov-io @guillep2k @lafriks @techknowlogick @GiteaBot @lunny @davidsvantesson