Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] feat: highlight issue references (#8101) #8404

Merged
merged 3 commits into from
Oct 7, 2019
Merged

[Backport] feat: highlight issue references (#8101) #8404

merged 3 commits into from
Oct 7, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 6, 2019

Backport of #8101

@grinat @6543
feat: highlight issue references with : (go-gitea#8101)
da69ad5 
* feat: highlight issue references with :

e.g. go-gitea#1287: my commit msg
e.g. ABC-1234: my commit msg

* ref: update model regex to consistent with issueNumericPattern

* test: check highlight issue with : in commits messages
@6543
Copy link
Member Author

6543 commented Oct 6, 2019

@lunny @techknowlogick backport ... drone passed

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2019
@6543
Copy link
Member Author

6543 commented Oct 7, 2019

@guillep2k point

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2019
@techknowlogick techknowlogick added this to the 1.9.4 milestone Oct 7, 2019
@techknowlogick
Copy link
Member

ping LG-TM bot

@techknowlogick techknowlogick merged commit c9b8c12 into go-gitea:release/v1.9 Oct 7, 2019
@6543 6543 deleted the backports_8101 branch October 7, 2019 09:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.4
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @techknowlogick @lunny @guillep2k @GiteaBot @grinat