Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close related pull requests when deleting head repository or head branch (#9927) #9974

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2020

partial backport from #9927

  • fix pull view when head repository or head branch missed and close related pull requests when delete branch
  • fix pull view broken when head repository deleted
  • close pull requests when head repositories deleted
  • Add tests for broken pull request head repository or branch
  • fix typo
  • ignore special error when close pull request

Co-authored-by: Lauris BH lauris@nix.lv

…lated pull requests when delete head repository or head branch (go-gitea#9927)

* fix pull view when head repository or head branch missed and close related pull requests when delete branch

* fix pull view broken when head repository deleted

* close pull requests when head repositories deleted

* Add tests for broken pull request head repository or branch

* fix typo

* ignore special error when close pull request

Co-authored-by: Lauris BH <lauris@nix.lv>
@lunny lunny added the type/bug label Jan 25, 2020
@lunny lunny added this to the 1.11.0 milestone Jan 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2020
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2020
@lunny lunny merged commit 16f7b43 into go-gitea:release/v1.11 Jan 25, 2020
@lunny lunny deleted the lunny/close_pr_branch_deleted branch January 25, 2020 09:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants