Feature/daterange #307
Merged
Feature/daterange #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.7.0...v1.7.1) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/jackc/pgconn](https://github.com/jackc/pgconn) from 1.14.0 to 1.14.1. - [Changelog](https://github.com/jackc/pgconn/blob/master/CHANGELOG.md) - [Commits](jackc/pgconn@v1.14.0...v1.14.1) --- updated-dependencies: - dependency-name: github.com/jackc/pgconn dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Add DefaultAlias option to TableSQLBuilder
gen/ -> .gen/
Fix typo in README
…querying 10x mysql db info querying speedup
This adds support for statements such as `SELECT ... FOR UPDATE OF table NOWAIT` where `OF table` could not be specified previously. Fixes go-jet#285.
Add support for OF in row lock clauses
go-jet
reviewed
Feb 2, 2024
go-jet
reviewed
Feb 2, 2024
go-jet
reviewed
Feb 2, 2024
go-jet
reviewed
Feb 2, 2024
go-jet
reviewed
Feb 2, 2024
|
Hi @sarkan-ag5, Nice work overall. Couple of additional comments:
|
go-jet
reviewed
Feb 2, 2024
go-jet
reviewed
Feb 9, 2024
sarkan-ag5
force-pushed
the
feature/daterange
branch
from
d4af106
to
9e0879c
Compare
go-jet
reviewed
Feb 13, 2024
go-jet
reviewed
Feb 13, 2024
go-jet
reviewed
Feb 13, 2024
go-jet
reviewed
Feb 13, 2024
|
Looks, good. The next steps would be to update generator and add integration tests. |
sarkan-ag5
force-pushed
the
feature/daterange
branch
from
e48d2a7
to
b4634f9
Compare
go-jet
reviewed
Feb 16, 2024
go-jet
reviewed
Feb 16, 2024
…b.com/google/uuid-1.6.0 Bump github.com/google/uuid from 1.3.0 to 1.6.0
This change improves performance for generating mysql models for databases with large number of tables. In my local testing for a database with about 1000 tables and 140k columns, generation time was reduced from about 1h to less than one second.
…rator-performance Improve performance of mysql generator
mysql: added a helper to compare UUID strings with uuid_to_bin
go-jet
reviewed
Feb 24, 2024
|
I think we are close now to merge this PR. Could you squash all the commits into one. I'm not completely sure but if I do squash and merge your contribution might be deleted from git history. |
plus and minus infinity keyword tests implemented range table tests added skip cockroach db added select test case added for range fields generator modified to generate correct types generator tests modified to include sample range table model and template generators modified to support range fields returning the T in UPPER and LOWER functions raw ranges implemented bounds set as optional dep modified dependencies modified and issue fixed range expression with templates implemented rangeExpression change to make it more type safe third parameter of constructor function fixed literals removed, functions added tests modified constructor functions used for creating range expressions NumRange converted to a constructor function from literal range_lower and range_upper renamed to lower_bound and upper_bound range literal removed PlusInfinity and MinusInfinity implemented int4 and int8 castings added issues fixed and tests checked number, ts, tstz literal and cast implemented date range literal expression modified and raw function used parent type converted from RangeExpression to Expression range type implemented for postgres range column type, function and literal expression implemented CONTAINS and OVERLAP operations added for range expressions range expressions implemented
sarkan-ag5
force-pushed
the
feature/daterange
branch
from
121d39b
to
893567d
Compare
|
Looks great. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for PostgreSQL range type fields. With this enhancement, Jet gains the ability to handle PostgreSQL range types seamlessly, enabling users to define and manipulate range-based data directly. The implementation is based on PostgreSQL documents.