feat: implement -context-only
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 90.00% 90.44% +0.44%
==========================================
Files 1 1
Lines 130 136 +6
==========================================
+ Hits 117 123 +6
Misses 9 9
Partials 4 4
☔ View full report in Codecov by Sentry. |
|
Looks great! I appreciate you added the documentation as well :) |
tmzane
reviewed
Oct 21, 2023
As described in go-simpler#13, third-party implementations of `slog.Handler` can choose to take values out of a context to supplement the attributes already used. An example of this in my day job is adding trace IDs to enhance serviceability. This change adds the ability to optionally identify `slog` methods that do not take a context and so prevent the ability to take values from that context. Any matches can be resolved by appending `Context` to the method. For example, `slog.Info` becomes `slog.Context`.
mattdowdell
force-pushed
the
matt/context-only
branch
from
3f6f30d
to
b563390
Compare
mattdowdell
commented
Oct 22, 2023
tmzane
approved these changes
Oct 22, 2023
|
@mattdowdell I've updated the report message and rearranged the options slightly. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #13, third-party implementations of
slog.Handlercan choose to take values out of a context to supplement the attributes already used. An example of this in my day job is adding trace IDs to enhance serviceability.This change adds the ability to optionally identify
slogmethods that do not take a context and so prevent the ability to take values from that context. Any matches can be resolved by appendingContextto the method. For example,slog.Infobecomesslog.InfoContext.