Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement -key-naming-case #15

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: implement -key-naming-case #15

merged 3 commits into from
Oct 25, 2023

Conversation

tmzane
Copy link
Member

@tmzane tmzane commented Oct 24, 2023

As previously suggested by @mattdowdell in #13.

@mattdowdell PTAL, maybe you have something to add :)

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (1301dc6) 90.44% compared to head (46e25aa) 84.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   90.44%   84.92%   -5.52%     
==========================================
  Files           1        1              
  Lines         136      199      +63     
==========================================
+ Hits          123      169      +46     
- Misses          9       24      +15     
- Partials        4        6       +2     
Files Coverage Δ
sloglint.go 84.92% <73.01%> (-5.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattdowdell mattdowdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one, it's greatly appreciated. The code looks good; I just have a couple of small suggestions but I'd be equally happy if they were skipped.

sloglint.go Show resolved Hide resolved
@tmzane tmzane merged commit b2f5791 into main Oct 25, 2023
5 of 7 checks passed
@tmzane tmzane deleted the key-naming-case branch October 25, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants