Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to internal/log #837

Merged
merged 1 commit into from
Mar 1, 2022
Merged

chore: switch to internal/log #837

merged 1 commit into from
Mar 1, 2022

Conversation

iwpnd
Copy link
Member

@iwpnd iwpnd commented Feb 27, 2022

As discussed I switched to the internal logger and changed current print statements to their respective log level to the best of my knowledge. Also as discussed I did not touch the math package. #831

@coveralls
Copy link

coveralls commented Feb 27, 2022

Pull Request Test Coverage Report for Build d9b676b62-PR-837

  • 2 of 23 (8.7%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 45.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
atlas/map.go 0 1 0.0%
provider/postgis/util.go 0 1 0.0%
server/handle_map_capabilities.go 0 2 0.0%
internal/log/log.go 0 3 0.0%
atlas/atlas.go 0 4 0.0%
provider/postgis/postgis.go 2 12 16.67%
Totals Coverage Status
Change from base Build e593b4f85: -0.01%
Covered Lines: 5486
Relevant Lines: 12156

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me get your other PR merged into v0.15.x and then you can rebase this branch onto it.

Thanks for the tackling this issue!

@ARolek ARolek merged commit 2fad340 into go-spatial:v0.15.x Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants