You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this PR is to make tests pass on Apple silicon without breaking tests for x86. The assumption (possibly incorrect) is that 8 places of precision is enough for scale demoninator, pixel width and height, and bounding box.
There's more going on here than just precision. I tried getting the TestGenerateTilesForBounds test passing without fully understanding it, but now realize it's failing on arm64 but not amd64 because overflow of unsigned ints is implementation-specific (see golang/go#52943). We'll need a different solution for that test case.
Looking for feedback, including advice on other approaches. I've never used Tegola or anything go-spatial before a couple weeks ago, so I'm assuming there are probably obvious things I'm missing. Any pointers are appreciated.
TestGenerateTilesForBounds is failing in master because of a bug in go-spatial/geom which is fixed in more recent versions, but it's not a simple upgrade because many of the functions Tegola relies on have been removed. I've worked through most of it, but the one piece I'm missing now is the ability to transform a geom.Extent of SRID 3857 to SRID 4326. The geom package doesn't seem to include that capability. If such a capability already exists, can you point me to it?
The precision changes in this PR aren't enough to make tests pass after the go-spatial/geom upgrade. geom must be doing math differently enough that floats end up being substantially different in some cases (e.g., -1.0021200154904785e+07 instead of -1.017529720390625e+07).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jchamberlain
force-pushed
the
fix-tests-on-apple
branch
from
The purpose of this PR is to make tests pass on Apple silicon without breaking tests for x86. The assumption (possibly incorrect) is that 8 places of precision is enough for scale demoninator, pixel width and height, and bounding box.