enhance(api/scm)!: return affected repos in API response and do not assume 404 on GetRepo error #5101
KellyMerrickreviewdog.yml
on: pull_request
diff-review
1m 26s
full-review
1m 34s
Annotations
20 errors
|
diff-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
diff-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
diff-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
diff-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
diff-review:
database/log/create.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
database/log/index.go#L19
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
database/log/table.go#L46
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
full-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
full-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
full-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
full-review:
database/hook/update.go#L15
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
database/hook/count_repo.go#L14
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
database/hook/table.go#L60
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|