fix(graph): return proper error on complex builds #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do it in the other spot too
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
- Coverage 68.30% 68.27% -0.04%
==========================================
Files 317 317
Lines 13612 13618 +6
==========================================
Hits 9298 9298
- Misses 3847 3853 +6
Partials 467 467
|
plyr4
approved these changes
Nov 24, 2023
ecrupper
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes go-vela/community#883
the error returned when complexity is high wasn't properly formatted, so it couldn't be displayed in UI like other errors; you would just end up with a generic internal network error without any other information. this should help signal to the user what is going on better, though maybe the message itself could be tweaked even more?!