chore: minor tweaks for local dev #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 317 317
Lines 13641 13641
=======================================
Hits 9326 9326
Misses 3848 3848
Partials 467 467 |
ecrupper
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of minor tweaks and fixes for annoyances i intend to carry over to the other core repos if accepted:
make upthere's a 95%+ chance i will attempt to access the stack before it is ready (mainly due to postgres service taking a while on my machine). this is fixed by adding a health check for postgres and making sure the server doesn't start until it's healthy. could maybe tweak interval to check more frequently. lmk.docker-compose->docker compose. ref: https://www.docker.com/blog/announcing-compose-v2-general-availability/ . i don't want to alias something that is deprecated, so i typically apply this edit locally before i runmake ...