Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock): add approve build to mock #1024

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

ecrupper
Copy link
Contributor

Planning on adding approve build to the SDK so need this mock

@ecrupper ecrupper requested a review from a team as a code owner December 11, 2023 20:07
mock/server/build.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1024 (7bc9d44) into main (6fcde86) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         318      318           
  Lines       13754    13754           
=======================================
  Hits         9325     9325           
  Misses       3956     3956           
  Partials      473      473           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timhuynh94 timhuynh94 merged commit 140d2b1 into main Dec 11, 2023
11 of 12 checks passed
@timhuynh94 timhuynh94 deleted the fix/mock/approve-build branch December 11, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants