Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing ProcessWebhook so that the deployment ref is only set once #1054

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

claire1618
Copy link
Contributor

Deleting the second instance of deployment.SetRef() due to errors it was causing when in dev when a deployment was created in prod

@claire1618 claire1618 requested a review from a team as a code owner February 2, 2024 18:03
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4d810d) 67.31% compared to head (af87088) 67.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   67.31%   67.30%   -0.01%     
==========================================
  Files         330      330              
  Lines        9471     9470       -1     
==========================================
- Hits         6375     6374       -1     
  Misses       2622     2622              
  Partials      474      474              
Files Coverage Δ
scm/github/webhook.go 90.60% <ø> (-0.03%) ⬇️

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm

@claire1618 claire1618 merged commit f2f177c into main Feb 2, 2024
12 of 13 checks passed
@claire1618 claire1618 deleted the fix/deployment/ref branch February 2, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants