Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build_tokens): constants for build tokens + refactor login type #276

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

ecrupper
Copy link
Contributor

Types PR for Epic 1: Build Tokens.

Changes:

  • library.Login type has been changed to library.Token to be more general, as there will be multiple token types.
  • new token type constants, which will be declared as claims in JWT tokens created and distributed by token manager.
  • user hash field being deprecated, as its previous purpose was to be a signing key for all user access tokens for a single user. Going forward, we will be using a single private key in the server env to generate all tokens.

@ecrupper ecrupper requested a review from a team as a code owner February 21, 2023 21:23
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #276 (5677451) into main (78d266f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   96.93%   96.93%   -0.01%     
==========================================
  Files          57       57              
  Lines        6306     6303       -3     
==========================================
- Hits         6113     6110       -3     
  Misses        143      143              
  Partials       50       50              
Impacted Files Coverage Δ
database/user.go 87.83% <ø> (-0.25%) ⬇️
library/user.go 100.00% <ø> (ø)
library/token.go 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants