fix(build): updating step refresh logic #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyr4
commented
Feb 13, 2020
| @@ -1042,18 +1043,20 @@ refreshBuildSteps model org repo buildNumber = | |||
| Success steps -> | |||
| Cmd.batch <| | |||
| List.map | |||
| (\step -> getBuildStep model org repo buildNumber <| String.fromInt step.number) | |||
| (\step -> | |||
| if not <| isComplete step.status then | |||
There was a problem hiding this comment.
here I added step refresh conditional
plyr4
commented
Feb 13, 2020
| <| | ||
| filterCompletedSteps steps | ||
|
|
||
| _ -> | ||
| Cmd.none | ||
| in | ||
| if shouldRefresh model.build then |
There was a problem hiding this comment.
here I removed the 'build is complete' restriction
plyr4
commented
Feb 13, 2020
| @@ -1081,16 +1084,7 @@ shouldRefresh : WebData Build -> Bool | |||
| shouldRefresh build = | |||
| case build of | |||
| Success bld -> | |||
| case bld.status of | |||
There was a problem hiding this comment.
I added a helper, so this code is easier to read
plyr4
commented
Feb 13, 2020
| @@ -664,6 +665,24 @@ toStatus status = | |||
| succeed Error | |||
|
|
|||
|
|
|||
| {-| isComplete : helper to determine if status is 'complete' | |||
There was a problem hiding this comment.
here I consider success failure and error to be "completed" states
wass3r
approved these changes
Feb 13, 2020
plyr4
added a commit
that referenced
this pull request
Aug 19, 2022
wass3r
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.