fix(kubernetes): Make Executor TailContainer before RunContainer #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kubernetes runtime needs to start asking for logs before the container is created, or logs from short-lived steps might be gone by the time TailContainer starts. The Docker runtime, however, needs to RunContainer first or the docker engine will complain that the container does not exist. So, we use a special `runCtx` to let the Docker Runtime's TailContainer know when RunContainer has finished to allow it to delay pulling logs until the container exists.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 78.91% 77.92% -0.99%
==========================================
Files 67 67
Lines 4870 4907 +37
==========================================
- Hits 3843 3824 -19
- Misses 884 943 +59
+ Partials 143 140 -3
|
|
This makes use of a new Is there a better signaling primitive to synchronize the stream+TailContainer go routine with when the outer scope finishes RunContainer? |
|
Oops. I hit the wrong button and closed it. :( |
cognifloyd
changed the title
|
I switched from a Context to a plain channel. That feels a bit cleaner. |
cognifloyd
commented
Feb 26, 2022
The purpose is a bit clearer this way
cognifloyd
force-pushed
the
stream-before-run
branch
from
1043387
to
9973e77
Compare
> if statements should only be cuddled with assignments (wsl)
|
I'm not confident this is a good fix. I'm looking at alternatives |
|
Alternate version in #286 |
cognifloyd
changed the title
6 tasks
|
Closing in favor of #303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make Kubernetes log capture more robust without changing the behavior for the Docker runtime.
The Kubernetes runtime needs to start asking for logs before the container is created, or logs from short-lived steps might be gone by the time TailContainer starts.
The Docker runtime, however, needs to RunContainer first or the docker engine will complain that the container does not exist. So, we use a special channel to let the Docker Runtime's TailContainer know when RunContainer has finished to allow it to delay pulling logs until the container exists.