Revert "fix: Allow log streaming to take longer than build execution … #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 81.39% 81.23% -0.17%
==========================================
Files 69 68 -1
Lines 5379 5333 -46
==========================================
- Hits 4378 4332 -46
Misses 856 856
Partials 145 145
|
ecrupper
approved these changes
Dec 12, 2022
|
No. Please don't do this. Just revert this part of that PR: e882fd1 |
|
can confirm that reverting just that commit seems to take care of the issue. |
|
closing in favor of #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#390)"
This reverts commit b50e19f.
Temporarily reverting these changes while we investigate a bug in the delayed context cancelling.