Update to Godot Engine 4.3 dev #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gitignore rules. Adjust code style settings for C++, ObjC, and Java. Update CI workflow to generate wiki documentation from XML files. Add comprehensive Gitignore rules for various generated files and IDE-specific files.
Changed include paths for physics related classes to match new directory structure.
…nheritance for HydroRigidBody, WaterArea3D, WatercraftBallast, WatercraftPropulsion, and WatercraftRudder.
- Added a missing newline at the end of the file.
Include third-party types in the hydro module for better functionality.
jonri
reviewed
Mar 15, 2024
| "thirdparty/src/water_area.cpp", | ||
| "thirdparty/src/watercraft_ballast.cpp", | ||
| "thirdparty/src/watercraft_propulsion.cpp", | ||
| "thirdparty/src/watercraft_rudder.cpp", |
There was a problem hiding this comment.
What advantage does moving these files bring?
There was a problem hiding this comment.
I'm not sure how to disable the copyright header replacement.
There was a problem hiding this comment.
Another way is to add your copyright with SPDX short tag.
GODOT ENGINE license boiler plate
Copyright (c) 2019 Jon Ring
SPDX-License-Identifier: MIT
|
|
||
| #include "src/register_types.h" | ||
| #include "modules/hydro/thirdparty/src/register_types.h" |
There was a problem hiding this comment.
This appears to be incompatible with building the module using custom_modules=... with a directory not named modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably want to wait til 4.3 is released.