Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android Themed Icons #5572

Closed
lucasnlm opened this issue Oct 11, 2022 · 3 comments · Fixed by godotengine/godot#97517
Closed

Add support for Android Themed Icons #5572

lucasnlm opened this issue Oct 11, 2022 · 3 comments · Fixed by godotengine/godot#97517

Comments

@lucasnlm
Copy link

lucasnlm commented Oct 11, 2022

Describe the project you are working on

Android 13 introduces a new kind of customization: Themed Icons.
With it, it's possible to make the app's icons use the theme color.

Example:

  • Godot already supports Adaptive Icons.

Describe the problem or limitation you are having in your project

Currently Godot doesn't support Themed Icons without create a custom project.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Godot could have a theme icon field in the Launcher Icons options.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Basicly, Godot supports adaptive icons with the following XML:

<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
    <background android:drawable="@mipmap/icon_background"/>
    <foreground android:drawable="@mipmap/icon_foreground"/>
</adaptive-icon>

By adding one line, it will support themed icons (<monochrome android:drawable="@mipmap/icon_monochrome"/>:

<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
    <background android:drawable="@mipmap/icon_background"/>
    <foreground android:drawable="@mipmap/icon_foreground"/>
    <monochrome android:drawable="@mipmap/icon_monochrome"/>
</adaptive-icon>

If this enhancement will not be used often, can it be worked around with a few lines of script?

If not used, all we have to do is omit the <monochrome android:drawable="@mipmap/icon_monochrome"/> line and it will work as is today.

Is there a reason why this should be core and not an add-on in the asset library?

We already support Adaptive Icons and Themed Icons is part of it.
By adding this Godot will also to encourage the right Android customization support.

@Calinou
Copy link
Member

Calinou commented Oct 12, 2022

Feel free to open a pull request for this 🙂

@RustoMCSpit
Copy link

update?

@AThousandShips AThousandShips changed the title Add support to Android Themed Icons Add support for Android Themed Icons Nov 1, 2023
@Calinou
Copy link
Member

Calinou commented Nov 1, 2023

update?

To my knowledge, nobody is currently working on this, but we welcome pull requests. The files to modify are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants