Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Android Themed Icons (monochrome) #97517

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add support for Android Themed Icons (monochrome) #97517

merged 1 commit into from
Sep 27, 2024
+45 −6

Conversation

syntaxerror247
Copy link
Contributor

@syntaxerror247 syntaxerror247 commented Sep 26, 2024 •
edited
Loading

This PR adds support for Android Themed icons.

Closes godotengine/godot-proposals#5572

demo.mp4

@syntaxerror247 syntaxerror247 requested review from a team as code owners September 26, 2024 23:24
@syntaxerror247 syntaxerror247 changed the title android_themed_icons Add support for Android Themed Icons Sep 27, 2024
@clayjohn clayjohn added this to the 4.x milestone Sep 27, 2024
m4gr3d
m4gr3d approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m4gr3d m4gr3d modified the milestones: 4.x, 4.4 Sep 27, 2024
@akien-mga akien-mga changed the title Add support for Android Themed Icons Add support for Android Themed Icons (monochrome) Sep 27, 2024
@akien-mga
Copy link
Member

Could you amend the commit message to be more explicit and follow our guidelines? https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

This PR's title would be a good commit message.

(I'd normally do it myself but it seems like you toggled off the option that lets repo maintainers update this PR directly.)

@syntaxerror247
Copy link
Contributor Author

I have just turned on edits by maintainers. You can now set it whatever you want.

@akien-mga
Copy link
Member

akien-mga commented Sep 27, 2024 •
edited
Loading

Thanks, updated :)
This should be ready to merge after it passes CI again.

@akien-mga akien-mga merged commit 76a1359 into godotengine:master Sep 27, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@syntaxerror247 syntaxerror247 deleted the android-themed-icon branch September 27, 2024 13:01
@lucasnlm
Copy link
Contributor

Nice! @syntaxerror247 thanks for implement it! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
feature proposal platform:android topic:export
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Add support for Android Themed Icons
5 participants
@syntaxerror247 @akien-mga @lucasnlm @m4gr3d @clayjohn