Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmationDialog misses theme overrides section #86712

Open
MathiasBaumgartinger opened this issue Jan 2, 2024 · 2 comments
Open

ConfirmationDialog misses theme overrides section #86712

MathiasBaumgartinger opened this issue Jan 2, 2024 · 2 comments

Comments

@MathiasBaumgartinger
Copy link

Tested versions

  • Reproducible in 4.1.3, 4.2.1, 4.2

System information

Manjaro Linux (KDE)

Issue description

ConfirmationDialog does not show a section for theme override. This is really confusing because the user would expect the internal panel of the confirmation dialog to have the color of the set theme which is not the case, as internally, the override is set anyways. Interestingly, an AcceptDialog (parent in the inhertiance chain) shows the section in the inspector properly (see screenshots below).

image
image

Steps to reproduce

Create ConfirmationDialog in editor and go to inspector, theme overrides will be missing.

The unexpected output can be seen in the remote node hierarchy. Navigate to the ConfirmationDialog and find the internal panel child. It will have a theme override applied:
image

Minimal reproduction project (MRP)

Not necessary

MathiasBaumgartinger pushed a commit to boku-ilen/landscapelab that referenced this issue Jan 2, 2024
…s or other properties

Current usage: setting cluster_size of GameObjectClusterCollection

Refs: #334, #333
Limitation: godotengine/godot#86712
@jsjtxietian
Copy link
Contributor

Yes it is confusing. I find that add the same setting as AcceptDialog for ConfirmationDialog in default_theme.cpp can make the ui appear again, but I'm not sure whether it's the correct way of fixing this.

@MathiasBaumgartinger
Copy link
Author

An easy workaround for now:

@export var panel_style: StyleBox

func _ready():
    add_theme_stylebox_override("panel", panel_style)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants