Fix physics hover when moving mouse from Control to Control
#81291
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the case was not considered, that the mouse can be at the same time over a `Control` node and over a `CollisionObject3D`. Make sure that physics mouseover is dropped when moving from a MouseFilterPass-Control-Node to a MouseFilterStop-Control-Node.
|
Any idea when this might get fixed - is it looking optimistic that this will be approved & merged for 4.3? I'm experiencing a related bug with input_event on CollisonObject3Ds firing even when input has already been handled by the UI. |
|
@JohnLamontagne I have opened #87362 which fixes this issue. It works based on the minimum reproducible examples posted on the PR, but it needs more reviews to make sure it doesn't introduce any new issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the case was not considered, that the mouse can be at the same time over a
Controlnode and over aCollisionObject3D.Make sure that physics mouseover is dropped when moving from a MouseFilterPass-Control-Node to a MouseFilterStop-Control-Node.
resolve #81287
based on #67791 (not cherry-pickable to 4.1)
I tried to do a simple backport of the change to 4.1, but it didn't fix the problem.