Bind remaining theme properties to their respective classes #81551

YuriSizov · 2023-09-11T19:50:51Z

Follow-up to #81312 and #79311 et al.

This PR adds binds for GraphEdit/GraphElement/GraphNode, which were skipped before due to a rework. Mostly this is straight-forward implementation of the theme cache and the new binds. But I changed one thing. I noticed that GraphEdit uses the port icon of the GraphNode type, but it doesn't fetch it through specific graph nodes, instead it only reads it from the theme. This means that if individual graph nodes have overrides or themes applied directly to them, we don't account for that. That is despite all related code operating in a context of specific graph nodes. So I adjusted these parts to use the port icon relevant to each node. (cc @Geometror).

This also adds binds for Window, which was skipped before due to a complicated code organization. I've used the power of friendship 🌈🙌 to access the cache directly from Viewport, which should do it for now. I still want to move embedded window drawing code back into Window at some point.

Finally, this adds theme cache entries/direct cache access to a few places that previously missed it. Some theme properties are now exposed to other classes via friendships or public getters for convenience. (cc @KoBeWi for ColorPicker/ColorMode related changes).

This removes all string-based theme access from `scene/` classes. Everything is cached and statically typed now.

YuriSizov · 2023-09-12T13:09:38Z

Added some fixes for TextEdit/CodeEdit. I made a typo when adding the new macros and one of the properties was bound with an incorrect type.

There was also a weird bit of code that I ignored before, that fetched theme properties of CodeEdit in TextEdit. The idea seems to be that TextEdit handles some CodeEdit-specific stuff internally, so it needs some of the theme items from its extending class. So some properties weren't even bound on CodeEdit, and I also suspect the way it was coded doesn't work with local theme overrides. #74843 recently added to the confusing code too.

So I reworked it to bind properties on the correct class, and then fetch the values using virtual methods that the extending class implements. Should be safe and properly separated now.

scene/gui/grid_container.cpp

scene/gui/margin_container.cpp

scene/gui/split_container.cpp

scene/main/window.h

scene/gui/graph_node.h

scene/gui/graph_edit.cpp

This adds binds for GraphEdit/GraphElement/GraphNode, which were skipped before due to a rework. This also adds binds for Window, which was skipped before due to a complicated code organization. Also adds theme cache entries/direct cache access to a few places that previously missed it. Some theme properties are now exposed to other classes via friendships or public getters for convenience. This removes all string-based theme access from scene/ classes.

Geometror

Primarily reviewed the GraphEdit related stuff. The changes beyond the theme caching make sense to me. Nice work!

YuriSizov · 2023-09-14T13:31:03Z

Thanks for reviews!

scene/gui/code_edit.cpp

scene/gui/text_edit.h

YuriSizov added enhancement topic:gui labels Sep 11, 2023

YuriSizov added this to the 4.2 milestone Sep 11, 2023

YuriSizov requested review from KoBeWi and Geometror September 11, 2023 19:50

YuriSizov requested review from a team as code owners September 11, 2023 19:50

YuriSizov force-pushed the gui-cache-all-the-theme branch 3 times, most recently from 22722a9 to f40364a Compare September 12, 2023 13:09

This was referenced Sep 12, 2023

Use bound theme properties for documentation #81573

Merged

Make GraphEdit toolbar more customizable #81582

Merged