Fix SubViewport physics picking #87385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the logic of `handle_input_locally` for physics picking.
adamscott
reviewed
Jan 24, 2024
Comment on lines
+741
to
+748
| if (!handle_input_locally) { | ||
| Viewport *vp = this; | ||
| while (!Object::cast_to<Window>(vp) && vp->get_parent()) { | ||
| vp = vp->get_parent()->get_viewport(); | ||
| } | ||
| vp->local_input_handled = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Just to be sure, you seem to skip every viewport (even ones with local_input_handled == true until the last one, then you set local_input_handled to false.
Is this what you want?
There was a problem hiding this comment.
This PR intends to treat handle_input_locally for physics picking in the same way as it is treated in other places. That includes skipping viewports with local_input_handled == true.
The fact that currently handle_input_locally is treated differently in different parts of the code-base is the reason for the linked issue.
akien-mga
approved these changes
Jan 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the logic of
handle_input_locallyfor physics picking.resolve #84258
cherry-pick of #85665 from 4.2 to master.
I see this as an interim solution until #77926 gets reviewed.
I believe, that it is unlikely that #77926 gets reviews anytime soon, but since #84258 is quite nasty, I want to provide a bugfix-PR, that is easier to review and that already received some testing in 4.2.