Release mouse button presses on window focus change. #92419
Conversation
| @@ -4893,6 +4893,7 @@ LRESULT CALLBACK WndProc(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { | |||
| void DisplayServerWindows::_process_activate_event(WindowID p_window_id) { | |||
| WindowData &wd = windows[p_window_id]; | |||
| if (wd.activate_state == WA_ACTIVE || wd.activate_state == WA_CLICKACTIVE) { | |||
| last_button_state = 0; | |||
There was a problem hiding this comment.
Could this break drag&drop operations across applications? e.g. minimizing a game window, starting a file drag, hovering the mouse over the game window's taskbar icon, then releasing the mouse.
Or after #67531 is merged, drag&drop of Nodes between multiple windows of one game app, switching between them using alt+tab or hovering taskbar icon.
We have another notification for tracking "last Godot window unfocused", which might be a better fit here instead.
Also the button is released both on focus gain and loss for Windows, while only focus loss for the other OS.
There was a problem hiding this comment.
Should not break file dnd, but definitely will break 67531, so I guess getting current state instead of saving way (similar to #92415) might be better option.
|
Superseded by #92424 |
Prevent mouse button from been stuck when Alt-Tabbing.