-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelfiber: update go.opentelemetry.io/otel/semconv to v1.26.0 #1175
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces significant updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Middleware
participant Metrics
participant Tracing
Client->>Middleware: Send HTTP Request
Middleware->>Metrics: Record Request Duration
Middleware->>Tracing: Start Span
Tracing->>Metrics: Log Attributes
Middleware->>Client: Send HTTP Response
Metrics->>Tracing: End Span
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (2)
Files selected for processing (4)
Additional comments not posted (35)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR updates the otelfiber package to use the actual OpenTelemetry semantic conventions by upgrading to
go.opentelemetry.io/otel/semconv/v1.26.0
. As part of this update, several attributes that were previously in use have been deprecated and replaced.This leads to many changes because several current attribute names have been deprecated.
http.server_name
andnet.host.name
were both replaced byserver.address
. I believe thatservice.name
is the most suitable replacement for what was meant by the ServerName field.The minimum Go version will be bumped as well.
Fixes #1174
P.S. If everything looks fine, I'll update the workflow and README accordingly.
Summary by CodeRabbit
New Features
Status
function for enhanced tracing capabilities based on HTTP status codes.Improvements
ServerName
toServiceName
for better alignment with service-oriented terminology.Bug Fixes