Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ fix!: context key collisions #896

Open
wants to merge 3 commits into
base: v3-beta
Choose a base branch
from

Conversation

sixcolors
Copy link
Member

@sixcolors sixcolors commented Jan 2, 2024

Fixes context key collisions mentioned in issue gofiber/fiber#2684

related to gofiber/fiber#2781

BREAKING CHANGE

Intended for v3

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Jan 2, 2024
@sixcolors sixcolors changed the title ♻️ fix: context key collisions ♻️ fix!: context key collisions Jan 2, 2024
@sixcolors sixcolors changed the base branch from main to v3-beta January 3, 2024 16:41
@nickajacks1
Copy link
Member

The FromContext pattern is a lot easier to use! 👍
Are these the only middlewares in this repo that need updating?

@sixcolors
Copy link
Member Author

The FromContext pattern is a lot easier to use! 👍 Are these the only middlewares in this repo that need updating?

Appears that way. At least in core and contrib. 3rd party middleware were not reviewed.

@sixcolors
Copy link
Member Author

@ReneWerner87 I created a v3-beta branch, you can merge this into that. (PR set to merge there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants