change to SupportPackageIsVersion3 for gRPC

[gyuho]

Could we change https://github.com/gogo/protobuf/blob/master/plugin/grpc/grpc.go#L51 to version 3?

Now it's SupportPackageIsVersion3 in gRPC.

Related:

• grpc/grpc-go@e78224b
• vendor: gRPC, proto-gen would complain about grpc.SupportPackageIsVersion2 etcd-io/etcd#5671

Please feel free to close this if I am asking the wrong question.

Thanks!

[dongsupark]

+1.
I just stumbled across this issue, while building torus, which depends on etcd, which depends again on grpc. As a workaround, I had to manually revert grpc/grpc-go@e78224b to get the build working.

[ax-nathan]

+1

[beejeebus]

i created #187 to fix this issue.

[awalterschulze]

Sorry for the delay
You are talking about merging this commit
golang/protobuf@0c1f6d6
which requires this commit
golang/protobuf@545732f

[awalterschulze]

The file index concept in golang/protobuf to avoid variable name conflicts is fundamentally flawed. gogoprotobuf rather uses the filename as a suffix to its generated variables to avoid many more conflicts.

For example:

Running these two in the same folder

protoc --gogo_out=. a.proto
protoc --gogo_out=. b.proto

will produce two variables with the same index value (0) and thus same name in the same package which will result in a go compiler error.

So whether to merge this is an interesting question.

Clearly they incremented the version number because they added a populated field which changes the API semantics. So this needs to be taken seriously.

[awalterschulze]

@tamird can you remember where we or someone logged this issue? I want to link it again.

[awalterschulze]

Ok so it just links to the generated fileDescriptor. This should be easy to merge.

[awalterschulze]

Done 55bbb6b

[awalterschulze]

@tamird please ignore my question.

[gyuho]

Thanks a lot!